----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review159764 -----------------------------------------------------------
Fix it, then Ship it! client/src/main/java/org/apache/atlas/AtlasBaseClient.java (line 280) <https://reviews.apache.org/r/54058/#comment230814> Consider wrapping this inside: LOG.isDebugEnabled(). client/src/main/java/org/apache/atlas/AtlasBaseClient.java (line 299) <https://reviews.apache.org/r/54058/#comment230815> is ".toString()" necessary here? typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystemProvider.java (line 19) <https://reviews.apache.org/r/54058/#comment230839> This file has white-space changes only. Please review and revert. - Madhan Neethiraj On Dec. 19, 2016, 8:21 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54058/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2016, 8:21 p.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, > and Suma Shivaprasad. > > > Bugs: ATLAS-1311 > https://issues.apache.org/jira/browse/ATLAS-1311 > > > Repository: atlas > > > Description > ------- > > ATLAS-1311: Integration tests for the V2 Entity APIs > > > Diffs > ----- > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > e5bd65a8 > client/src/main/java/org/apache/atlas/AtlasBaseClient.java a95bf32d > client/src/main/java/org/apache/atlas/AtlasClient.java 47231a87 > client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 16556c8c > client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7cf > client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java a1935247 > intg/src/main/java/org/apache/atlas/model/SearchFilter.java 4d8b258e > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > 35f2f144 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java > 1a3c31c9 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > 6b2b2166 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystemProvider.java > 4e1cd36b > webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcbe > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java > 5756adb5 > webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java > dfd29b14 > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 8a663c28 > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java > ac4f9f1a > webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java > cc98207c > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12c > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 2529f0dd > webapp/src/main/resources/spring-security.xml 4ba30255 > webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605d > webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java 01e4d483 > > webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java > ec62112f > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java > de0a459b > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java > e37839a2 > > webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java > 2a4babae > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java > 325c25b4 > > webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java > 7e4db13f > > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java > 22bcc027 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java > c681a0f9 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java > ed37c3a1 > > webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java > 87bf9a89 > > Diff: https://reviews.apache.org/r/54058/diff/ > > > Testing > ------- > > UTs and ITs are running fine. mvn clean install -Pdist was successful > > > Thanks, > > Apoorv Naik > >
