> On Jan. 12, 2017, 11:15 a.m., Vimal Sharma wrote: > > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java, > > line 414 > > <https://reviews.apache.org/r/55436/diff/2/?file=1603249#file1603249line414> > > > > Alphanumeric characters should be fine. Didn't understand the change > > Jeff Hagelberg wrote: > This was causing intermittent test failures in at least the following two > tests: > testUpdate(org.apache.atlas.web.resources.TypesJerseyResourceIT) Time > elapsed: 0.031 sec <<< FAILURE! > org.apache.atlas.AtlasServiceException: Metadata service API > org.apache.atlas.AtlasBaseClient$APIInfo@619bfe29 failed with status 400 (Bad > Request) Response Body ({"error":"0fghLoh1UH: invalid name for ENTITY. Only > alphanumeric and _ are allowed."}) > at > org.apache.atlas.web.resources.TypesJerseyResourceIT.testUpdate(TypesJerseyResourceIT.java:117) > > > testDuplicateCreate(org.apache.atlas.web.resources.TypedefsJerseyResourceIT) > Time elapsed: 0.064 sec <<< FAILURE! > org.apache.atlas.AtlasServiceException: Metadata service API > org.apache.atlas.AtlasBaseClient$APIInfo@2f6e28bc failed with status 400 (Bad > Request) Response Body > ({"errorCode":"ATLAS40025E","errorMessage":"11ZoK6bFah: invalid name for > ENTITY. Only alphanumeric and _ are allowed."}) > at > org.apache.atlas.web.resources.TypedefsJerseyResourceIT.testDuplicateCreate(TypedefsJerseyResourceIT.java:93) > > This change fixes these intermittent failures. > > Jeff Hagelberg wrote: > These tests were failing because the initial character in the randomly > generated entity name was a digit. > > Vimal Sharma wrote: > Got it. The error message in AtlasTypeUtil.java (line 64) is misleading. > It would be fixed
Sure. I'll update the error message as well. - Jeff ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55436/#review161364 ----------------------------------------------------------- On Jan. 12, 2017, 7:21 p.m., Jeff Hagelberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55436/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2017, 7:21 p.m.) > > > Review request for atlas, David Kantor and Neeru Gupta. > > > Bugs: ATLAS-1386 > https://issues.apache.org/jira/browse/ATLAS-1386 > > > Repository: atlas > > > Description > ------- > > When using the GraphBackedTypeStore, many unnecessary gremlin queries are > executed as part of DSL query translated that are for things that cannot > possibly be types, for example field names and aliases. These changes > eliminate unnecessary queries and consolidate the type lookup for trait and > class types where it makes sense. > > > Diffs > ----- > > repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala > 569d3f947e49f205b3d48c7387ee4df39938deff > repository/src/main/scala/org/apache/atlas/query/Expressions.scala > ce21a597e79b684eaadc54f208f4a540d402f1b9 > repository/src/main/scala/org/apache/atlas/query/QueryParser.scala > 42d76c84d48b1e13c3666be8de00fcc3f2bcdea9 > repository/src/main/scala/org/apache/atlas/query/QueryProcessor.scala > ee95a20a0bdd447d907b21a5d5a0642f4142bade > repository/src/main/scala/org/apache/atlas/query/Resolver.scala > 0957c57156381bfae82409a3c88083f564d790e8 > repository/src/main/scala/org/apache/atlas/query/TypeUtils.scala > dfa7093bec25e8954634af2a3f55f357eb7d46a1 > > repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java > 1217e4af1c8bd63b191025ab9098b16ec0867a4c > repository/src/test/java/org/apache/atlas/query/QueryProcessorTest.java > PRE-CREATION > typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java > 1358159d9cdc6f36f3a34d7946707d329b10f9d3 > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java > dcb126454b9efc0b50f6835e6dd1371f3e16d359 > > Diff: https://reviews.apache.org/r/55436/diff/ > > > Testing > ------- > > All Atlas tests run, no regressions found. There were some tests that failed > both with and without these changes. > > > Thanks, > > Jeff Hagelberg > >
