----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55830/#review162597 -----------------------------------------------------------
client/src/main/java/org/apache/atlas/AtlasAdminClient.java (line 96) <https://reviews.apache.org/r/55830/#comment233962> set "cmdStatus = 0;" here, similar to line #88. Else the program will result in error return code (line #84). distro/src/conf/atlas-application.properties (line 209) <https://reviews.apache.org/r/55830/#comment233966> Please ensure that the metrics code uses appropriate default values for all these properties; a deployment would use these properties only if/when a different query needs to be used. distro/src/conf/atlas-application.properties (line 210) <https://reviews.apache.org/r/55830/#comment233965> Please update the query to exclude 'TRAIT's in the count. Same for the next query as well - line #211. intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetrics.java (line 71) <https://reviews.apache.org/r/55830/#comment233967> this comment is applicable for line #76 as well. - Madhan Neethiraj On Jan. 23, 2017, 4:57 a.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55830/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2017, 4:57 a.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Suma > Shivaprasad, and Vimal Sharma. > > > Bugs: ATLAS-1436 > https://issues.apache.org/jira/browse/ATLAS-1436 > > > Repository: atlas > > > Description > ------- > > ATLAS-1436: Metrics collection using gremlin > > > Diffs > ----- > > client/src/main/java/org/apache/atlas/AtlasAdminClient.java 19f95758 > client/src/main/java/org/apache/atlas/AtlasBaseClient.java d055b789 > distro/src/conf/atlas-application.properties 6fa066b6 > intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetrics.java > PRE-CREATION > repository/src/main/java/org/apache/atlas/services/MetricsService.java > PRE-CREATION > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > 02d74883 > webapp/src/main/resources/spring-security.xml 4ed88ece > webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java > eb2b2f6d > > Diff: https://reviews.apache.org/r/55830/diff/ > > > Testing > ------- > > mvn clean install -DskipITs executes successfully. > > > Thanks, > > Apoorv Naik > >
