----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55443/#review163439 -----------------------------------------------------------
Ship it! Query caching looks good! repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java (line 131) <https://reviews.apache.org/r/55443/#comment234893> FYI - I remember build failures when no space is present between "if" and "(" - due to checkstyle rules. Perhaps this is not enforced for all modules. I don't agree with many such rules; but it is good to not change existing code. Just wanted to bring to your attention. - Madhan Neethiraj On Jan. 29, 2017, 12:18 a.m., Jeff Hagelberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55443/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2017, 12:18 a.m.) > > > Review request for atlas, David Kantor and Neeru Gupta. > > > Bugs: ATLAS-1387 > https://issues.apache.org/jira/browse/ATLAS-1387 > > > Repository: atlas > > > Description > ------- > > Adds a compiled query cache to Atlas. This avoids the overhead of parsing > and translating DSL queries that have been previously executed. > > > Diffs > ----- > > common/pom.xml 0226541b2dd73e8a01f050982cb8b37f5fed9cab > common/src/main/java/org/apache/atlas/utils/LruCache.java PRE-CREATION > common/src/test/java/org/apache/atlas/utils/LruCacheTest.java PRE-CREATION > distro/src/conf/atlas-application.properties > 303ce7b00c93f2499e7b18c5f3a131b50c150b69 > > repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java > fb488cdfc7cef195ffc5221afb9a9109a6e92fc9 > > repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java > 6655085ee11c94addca1564cf77bbdb001c4586f > repository/src/main/java/org/apache/atlas/util/CompiledQueryCacheKey.java > PRE-CREATION > repository/src/main/java/org/apache/atlas/util/NoopGremlinQuery.java > PRE-CREATION > repository/src/main/scala/org/apache/atlas/query/QueryProcessor.scala > 5693c9ecc1a96154a8b0ac48256e5074dc041c5f > > repository/src/test/java/org/apache/atlas/util/CompiledQueryCacheKeyTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/55443/diff/ > > > Testing > ------- > > Ran all atlas tests, no regressions found. There were some tests that failed > both with and without these changes. > > > Thanks, > > Jeff Hagelberg > >
