----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56585/#review165369 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java (line 92) <https://reviews.apache.org/r/56585/#comment237203> throw error when entity is null? - Suma Shivaprasad On Feb. 13, 2017, 7:29 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56585/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2017, 7:29 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1544 > https://issues.apache.org/jira/browse/ATLAS-1544 > > > Repository: atlas > > > Description > ------- > > - AtlasEntityStoreV1 implementation updated to use EntityGraphMapper (instead > of StructVertexMapper, MapVertexMapper, ArrayVertexMapper classes) > - refactored EntityGraphDiscoveryContext and related classes > (IDBasedResolver, UniqAttributeBasedResolver) > - updated unit tests TestEntityREST and TestEntitiesREST; addressed the > issues caught by these unit tests > - AtlasObjectId updated to require typeName only when GUID is not specified. > Updated its constructors to make this intutive > - changes in discovery and resolver implementation > > > Diffs > ----- > > client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java be3088f > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5902463 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java af936cc > intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java > e4abda7 > intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java c23f4d5 > intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 02851c4 > intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 6d24d7e > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 7615057 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 4b23ecf > intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 3ba7a33 > intg/src/test/java/org/apache/atlas/TestUtilsV2.java f09a4b9 > intg/src/test/java/org/apache/atlas/type/TestAtlasObjectIdType.java 2a3ba55 > repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java > c4d5020 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 65de1e5 > > repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java > fb2c939 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java > 4cfc012 > > repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscovery.java > 38fca03 > > repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscoveryContext.java > cd92a11 > > repository/src/main/java/org/apache/atlas/repository/store/graph/EntityResolver.java > 35ddc7d > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/ArrayVertexMapper.java > ddd2242 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java > 2b0804f > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > 566207b > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStream.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java > b17cf90 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AttributeMutationContext.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > 14013fb > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > a0096c1 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > 255c52c > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityMutationContext.java > 310b455 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityStream.java > 1d939fe > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphMutationContext.java > 7dbedc7 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/IDBasedEntityResolver.java > 2ffd10e > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/InMemoryMapEntityStream.java > 0d0b949 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/InstanceGraphMapper.java > 7e87d39 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/MapVertexMapper.java > bb7aeb6 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java > edcc12d > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/UniqAttrBasedEntityResolver.java > f21896d > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java > 7505329 > > repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java > 6c791ba > webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java ea6d217 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java > fb02318 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasObjectIdConverter.java > b2de802 > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 5b3a4c2 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 1aac0f2 > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java > 9957f42 > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java > fd110cd > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java > 64593b7 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java > 9f03718 > > Diff: https://reviews.apache.org/r/56585/diff/ > > > Testing > ------- > > all unit tests pass > > > Thanks, > > Madhan Neethiraj > >
