-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56184/#review165848
-----------------------------------------------------------


Ship it!




Please rebase as there are some compilation errors due to further changes.

Verified that the table creation/updation/deletion are captured correctly by 
the Atlas Hook.

- Vimal Sharma


On Feb. 15, 2017, 10:18 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56184/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2017, 10:18 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Suma 
> Shivaprasad, and Vimal Sharma.
> 
> 
> Bugs: ATLAS-1499
>     https://issues.apache.org/jira/browse/ATLAS-1499
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1499: Notification processing using V2 Store
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ae6be843 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> edaede0c 
>   
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java
>  74acfdce 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java
>  1ef803c0 
>   repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 
> cf85b2fc 
>   server-api/src/main/java/org/apache/atlas/RequestContextV1.java bf731746 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  f2416810 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasAbstractFormatConverter.java
>  f1f3d18a 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java
>  aa14aff4 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasClassificationFormatConverter.java
>  dc740f55 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java
>  cb1390d1 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEnumFormatConverter.java
>  6d8e3aee 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverter.java 
> a7157a36 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java 
> 968d74fe 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java
>  b1dae56d 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java
>  6967c4f5 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasObjectIdConverter.java
>  11a020d8 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java
>  2b70c5e1 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java
>  920b48b0 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 440d75ce 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 852b124f 
>   webapp/src/test/java/org/apache/atlas/LocalAtlasClientTest.java c5616dfe 
>   
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java
>  873e5625 
>   
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java
>  f06f7912 
> 
> Diff: https://reviews.apache.org/r/56184/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install -DskipITs executed successfully.
> 
> UI/Manual testing details
> 
> 1. Manually created table in hive, showed up in graph and as an entity from 
> the search UI
> 2. Created a view from the above table and the lineage showed up in atlas 
> dashboard
> 3. added a column to the above table (changes could be seen on the UI)
> 4. altered table columns (changes couldn't be seen on the UI) **Error**
> 
> 
> Will be running HiveHookIT to verify more cases.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Reply via email to