> On Feb. 4, 2017, 6:39 p.m., Suma Shivaprasad wrote: > > Ship It! > > Jeff Hagelberg wrote: > How will this work for composite references? At least in V0 (I guess we > can call it that), objects referenced via a composite reference need to be > inlined.
This is being modelled by AtlasEntityWithExtInfo which could have AtlasEntity objects which will have only AtlasObjectId references. Thse child references would be available in referredEntities and can be retrived using their guid/transient id. - Suma ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56206/#review164250 ----------------------------------------------------------- On Feb. 4, 2017, 12:09 a.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56206/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2017, 12:09 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1522 > https://issues.apache.org/jira/browse/ATLAS-1522 > > > Repository: atlas > > > Description > ------- > > Currently child(composite) entities are allowed as attribute values in create > or update APIs. Allowing this to have only AtlasObjectId would avoid cycles > in the entity structure > > > Diffs > ----- > > client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 8d1bfa7 > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 0fb16c6 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 9494fe4 > > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java > 932a40d > intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java > 738f22f > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > c9b6e97 > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java fcd483c > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 8bdbe93 > intg/src/test/java/org/apache/atlas/TestUtilsV2.java 0756937 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java > c42f95f > > repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscoveryContext.java > 2d748da > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java > 0e1d9e6 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > 4c79cef > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > a989f76 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > e534d4f > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityMutationContext.java > f6e5055 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityStream.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/IDBasedEntityResolver.java > d02b5a1 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/InMemoryMapEntityStream.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/UniqAttrBasedEntityResolver.java > 76308a0 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java > 546cd0c > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java > e3b4efa > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasClassificationFormatConverter.java > da71c31 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java > bbfcc59 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEnumFormatConverter.java > 4f22437 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverter.java > 079f3be > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java > 7368c72 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java > f390e82 > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasObjectIdConverter.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java > 382d1ef > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java > 4b3dd4c > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 5107767 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java aa209f9 > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java > cfe9909 > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java > ee36fdf > > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java > d9bffe9 > > Diff: https://reviews.apache.org/r/56206/diff/ > > > Testing > ------- > > ENtityJerseyResourceIt tests failing . This is pending. > > > Thanks, > > Suma Shivaprasad > >
