----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57103/#review167035 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java (line 847) <https://reviews.apache.org/r/57103/#comment239172> Can result of traitNames be put into a HashMap instead so that we can avoid the expensive membership check operation in validateClassificationExists - Vimal Sharma On Feb. 28, 2017, 7:01 a.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57103/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2017, 7:01 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1601 > https://issues.apache.org/jira/browse/ATLAS-1601 > > > Repository: atlas > > > Description > ------- > > Add support for classification store, REST API for addition, deletion and gets > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java d58c514 > > repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java > 621b32f > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java > 6c372b3 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > c84f169 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > 09f69db > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > 3ba2190 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityMutationContext.java > 23e825e > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > d7adb3a > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java d1bef78 > > Diff: https://reviews.apache.org/r/57103/diff/ > > > Testing > ------- > > Tested through TestEntityREST > > > Thanks, > > Suma Shivaprasad > >
