----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57210/#review167512 -----------------------------------------------------------
Ship it! Ship It! - Sarath Subramanian On March 1, 2017, 10:09 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57210/ > ----------------------------------------------------------- > > (Updated March 1, 2017, 10:09 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1587 > https://issues.apache.org/jira/browse/ATLAS-1587 > > > Repository: atlas > > > Description > ------- > > - Consolidated the logic to populate AtlasEntityHeader from a vertext to > EntityGraphRetriever.toAtlasEntityHeader() > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java > e3eb52a > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > da06230 > > repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java > 4a98920 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > 44ca854 > > > Diff: https://reviews.apache.org/r/57210/diff/2/ > > > Testing > ------- > > - verified that the header has correct value for 'name' even for types not > derived from Asset (like storm_spout) > > > Thanks, > > Madhan Neethiraj > >
