----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57302/#review167929 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On March 4, 2017, 12:51 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57302/ > ----------------------------------------------------------- > > (Updated March 4, 2017, 12:51 a.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-1630 > https://issues.apache.org/jira/browse/ATLAS-1630 > > > Repository: atlas > > > Description > ------- > > 1. Introduce a new search endpoint in DiscoveryREST called ‘/basic’ – this is > in addition to existing /dsl and /fulltext > 2. This method should take the following query parameters: > a. query > b. type > c. classification > d. limit > e. offset > 3. Given ‘query’ should be matched against ‘entityText’ attribute > > g.V().has(‘entityText’,com.thinkaurelius.titan.core.attribute.Text.CONTAINS, > ‘query’) > 4. If ‘type’ is provided, add the following filter: > .has(‘__typeName’, T.in, [‘type’, ‘super-types-of-type’]) > 5. If ‘classification’ is provided, add the following filter: > .has(‘__traitNames’, T.in, [‘classification’, > ‘super-types-of-classification’]) > 6. limit/offset parameters.. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java > c4c0063 > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java c6be8f5 > > repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java > 21ce14d > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > 5628ed8 > > repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java > e4777be > > repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java > f076750 > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 7f75a27 > > > Diff: https://reviews.apache.org/r/57302/diff/4/ > > > Testing > ------- > > REST API testing suceeded. > > > Thanks, > > Sarath Subramanian > >
