----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57347/#review168067 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java Lines 403 (patched) <https://reviews.apache.org/r/57347/#comment240172> this for() loop is repeated for entityDef/classificationDef/structDef. Consider moving this block to a separate method and reuse. - Madhan Neethiraj On March 7, 2017, 12:26 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57347/ > ----------------------------------------------------------- > > (Updated March 7, 2017, 12:26 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1636 > https://issues.apache.org/jira/browse/ATLAS-1636 > > > Repository: atlas > > > Description > ------- > > Update hive_column model to remove inverseRef constraint on table attribute. > > > Diffs > ----- > > addons/models/patches/003-hive_column_update_table_remove_constraint.json > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java > fa4a480 > > > Diff: https://reviews.apache.org/r/57347/diff/2/ > > > Testing > ------- > > Models were updated. And creating hive_table with partition keys works with > column mapped correctly. > > > Thanks, > > Sarath Subramanian > >
