----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57352/#review168080 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On March 7, 2017, 2:12 a.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57352/ > ----------------------------------------------------------- > > (Updated March 7, 2017, 2:12 a.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-1646 > https://issues.apache.org/jira/browse/ATLAS-1646 > > > Repository: atlas > > > Description > ------- > > Steps to duplicate: > - Create a Tag with date attribute. > - Select *hive_table* and attempt to assign this new attribute to it. You > will receive an error. > - Apply the patch and duplicate the steps above. Tag will get associated. > > Implementation approach: > - Update *AtlasDateType* to include empty string as valid value. > - Added classification validation to *AtlasEntityStoreV1.addClassification* > methods. Handled invalid cases. > > Verification: > - UI interaction. > - Verify using V1 APIs and notice the date displayed in UTC format. Empty > date (0L) is displayed as *1970-01-01*. > > *CURL* > ``` > curl -X GET -u admin:admin -H "Content-Type: application/json" -H > "Cache-Control: no-cache" > "http://localhost:21000/api/atlas/entities/77cc9adb-7608-4f13-b94a-eaee3b056884"; > ``` > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java 0b124b2 > intg/src/test/java/org/apache/atlas/type/TestAtlasDateType.java 1b3bbc7 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > 518b52b > > > Diff: https://reviews.apache.org/r/57352/diff/2/ > > > Testing > ------- > > Updated unit tests. > Executed unit tests. > > > Thanks, > > Ashutosh Mestry > >
