----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57359/#review168087 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On March 7, 2017, 3:20 a.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57359/ > ----------------------------------------------------------- > > (Updated March 7, 2017, 3:20 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, Suma Shivaprasad, and Vimal Sharma. > > > Bugs: ATLAS-1649 > https://issues.apache.org/jira/browse/ATLAS-1649 > > > Repository: atlas > > > Description > ------- > > Same property was being used for externalizing the name of the DeleteHandler > which caused a conflict in Guice binding > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java > ee37e57c > > > Diff: https://reviews.apache.org/r/57359/diff/1/ > > > Testing > ------- > > Atlas starts up fine with the custom delete handler property for > SoftDeleteHandler and HardDeleteHandler > > > Thanks, > > Apoorv Naik > >