----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57351/#review168187 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/converters/AtlasObjectIdConverter.java Lines 104 (patched) <https://reviews.apache.org/r/57351/#comment240353> isAllUnassignedAttrs() - name is a little difficult to read. Consider renaming to something like hasAnyAssignedAttribute() repository/src/main/java/org/apache/atlas/repository/converters/AtlasObjectIdConverter.java Lines 107 (patched) <https://reviews.apache.org/r/57351/#comment240352> rInstance.getId().isAssigned() - this condition doesn't seem necessary. - Madhan Neethiraj On March 7, 2017, 7:05 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57351/ > ----------------------------------------------------------- > > (Updated March 7, 2017, 7:05 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, > Suma Shivaprasad, and Vimal Sharma. > > > Bugs: ATLAS-1648 > https://issues.apache.org/jira/browse/ATLAS-1648 > > > Repository: atlas > > > Description > ------- > > Fixed failures in: > Failed tests: > HiveMetastoreBridgeIT.testImportCreatedTable:79 » AtlasService Metadata > servic... > HiveHookIT.testAlterTablePartitionColumnType:1216->assertColumnIsRegistered:283->HiveITBase.assertEntityIsRegistered:158->HiveITBase.waitFor:202 > Assertions failed. Failing after waiting for timeout 80000 msecs > HiveHookIT.testAlterTableRename:889->createTrait:946 » AtlasService Metadata > s... > HiveHookIT.testTraitsPreservedOnColumnRename:1255->createTrait:946 » > AtlasService > > > Diffs > ----- > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > d640a81 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java > f8083de > > repository/src/main/java/org/apache/atlas/repository/converters/AtlasObjectIdConverter.java > a5ab8d7 > > > Diff: https://reviews.apache.org/r/57351/diff/2/ > > > Testing > ------- > > Failed ITs run successfully. > > > Thanks, > > Sarath Subramanian > >
