----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58159/#review170978 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java Line 1030 (original), 1030 (patched) <https://reviews.apache.org/r/58159/#comment243811> Typo notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java Line 145 (original), 145 (patched) <https://reviews.apache.org/r/58159/#comment243812> I think this was a local change. Please revert repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java Lines 33 (patched) <https://reviews.apache.org/r/58159/#comment243814> Context is not being used anywhere. Remove if not needed. repository/src/test/java/org/apache/atlas/repository/impexp/ZipSinkTest.java Lines 98 (patched) <https://reviews.apache.org/r/58159/#comment243816> Use Assert.fail("<some message>") repository/src/test/java/org/apache/atlas/repository/impexp/ZipSinkTest.java Lines 102 (patched) <https://reviews.apache.org/r/58159/#comment243817> Use Assert.fail("<some message>") repository/src/test/java/org/apache/atlas/repository/impexp/ZipSourceTest.java Lines 73 (patched) <https://reviews.apache.org/r/58159/#comment243818> Rename to verifyGuidRemovalOnImportComplete - Apoorv Naik On April 3, 2017, 10:45 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58159/ > ----------------------------------------------------------- > > (Updated April 3, 2017, 10:45 p.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-1709 > https://issues.apache.org/jira/browse/ATLAS-1709 > > > Repository: atlas > > > Description > ------- > > **Background** > Existing implementation is not supported by suite of unit tests. This impacts > sustainbility of the module. > > **Implementation** > Unit tests have been implemented to cover the top-level classes and the > supporting classes. > > The implementaion caused the classes to be moved from existing _webapp_ > module to _repository_. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java ea2a7038 > notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java > 77c17114 > > repository/src/test/java/org/apache/atlas/repository/impexp/ExportServiceTest.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/impexp/ZipSinkTest.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/impexp/ZipSourceTest.java > PRE-CREATION > repository/src/test/resources/dept-employee-test-utils.zip PRE-CREATION > repository/src/test/resources/logging-v1-full.zip PRE-CREATION > repository/src/test/resources/reporting-v1-full.zip PRE-CREATION > repository/src/test/resources/sales-v1-full.zip PRE-CREATION > repository/src/test/resources/stocks.zip PRE-CREATION > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > 097589f2 > webapp/src/main/java/org/apache/atlas/web/resources/ExportService.java > 159369cd > webapp/src/main/java/org/apache/atlas/web/resources/ImportService.java > eb81e3ce > webapp/src/main/java/org/apache/atlas/web/resources/ZipExportFileNames.java > c41ff56a > webapp/src/main/java/org/apache/atlas/web/resources/ZipSink.java c197d41a > webapp/src/main/java/org/apache/atlas/web/resources/ZipSource.java 8b2b9dfe > > > Diff: https://reviews.apache.org/r/58159/diff/1/ > > > Testing > ------- > > Verified REST APIs via CURL calls. They function as expected. > Verified the test suite via IntelliJ IDE and as part of module maven build. > > _ImportServiceTest_ > * Runs consistently from IntelliJ IDE. > * From _maven_ command line causes intermittent failures. > > > Thanks, > > Ashutosh Mestry > >
