----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58222/#review171785 -----------------------------------------------------------
Could you rebase the patch. - Sarath Subramanian On April 5, 2017, 2:51 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58222/ > ----------------------------------------------------------- > > (Updated April 5, 2017, 2:51 p.m.) > > > Review request for atlas, Madhan Neethiraj and Nixon Rodrigues. > > > Bugs: ATLAS-1721 > https://issues.apache.org/jira/browse/ATLAS-1721 > > > Repository: atlas > > > Description > ------- > > **Background** > After a successful import operation, the entities imported do not have audits > that clearly identifies their mode of creation. > > **Approach** > The _EntityChangeListener_ implements observer pattern. Existing > implementation does not have ability to pass parameter information to the > concrete implementation. > > The approach modifies the implementation such that it is possible to pass > parameters to the concrete implementations. This is done using generic > parameterized list. > > E.g. > ```java > void onEntitiesAdded(Collection<ITypedReferenceableInstance> entities, > Object... args) throws AtlasException; > ``` > > Within the _EntityAuditListener_, the parameter is read and the appropriate > choice of the _EntityAuditAction_ is passed. > > Modified _Enums.js_ to help UI handle the additional audit values. > > **Specifics** > _EntityAuditAction_ is modified to include additional _enum_ values. > > > Diffs > ----- > > client/src/main/java/org/apache/atlas/EntityAuditEvent.java 7eaa5563 > client/src/test/java/org/apache/atlas/EntityAuditEventTest.java > PRE-CREATION > dashboardv2/public/js/utils/Enums.js c779cd4c > > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java > 3f03c50a > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java > 0439adab > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > 32b1ea83 > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java > d9ce8c41 > > repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java > 7e828a18 > > server-api/src/main/java/org/apache/atlas/listener/EntityChangeListener.java > 256e839a > > webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java > 978b21d6 > > > Diff: https://reviews.apache.org/r/58222/diff/2/ > > > Testing > ------- > > Added unit tests for _EntityAuditAction_. > > Functional testing: > - Create entity using beeline/hive. Observe the value in _Audit_ tab. > - Perform import. Obeserve value in _Audit_ tab. > > > Thanks, > > Ashutosh Mestry > >
