----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58163/#review171783 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java Lines 206 (patched) <https://reviews.apache.org/r/58163/#comment244785> if there is no attribute with the given name, this will result in NPE. Please review and handle this case. repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java Lines 209 (patched) <https://reviews.apache.org/r/58163/#comment244787> if 'query' parameter has a value, I think we should add the attribute query string, instead of replacing it. String attrQuery = String.format("%s AND (%s *)", attrName, attrValue.replaceAll("\.", " ")); if (StringUtils.isEmpty(query)) { query = attrQuery; } else { query = String.format("(%s) AND (%s)"), query, attrQuery); } - Madhan Neethiraj On April 12, 2017, 8:21 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58163/ > ----------------------------------------------------------- > > (Updated April 12, 2017, 8:21 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Suma Shivaprasad. > > > Bugs: ATLAS-1710 > https://issues.apache.org/jira/browse/ATLAS-1710 > > > Repository: atlas > > > Description > ------- > > Implement the entity-lookup API > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java > bf1c80e8 > > repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java > 1044aaa8 > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > 571ce6ea > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 61f98475 > > > Diff: https://reviews.apache.org/r/58163/diff/2/ > > > Testing > ------- > > All UTs and ITs passed: > > mvn clean install > > > Thanks, > > Sarath Subramanian > >
