----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58343/#review171792 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On April 11, 2017, 10:35 a.m., Kalyani Kashikar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58343/ > ----------------------------------------------------------- > > (Updated April 11, 2017, 10:35 a.m.) > > > Review request for atlas, keval bhatt and Madhan Neethiraj. > > > Bugs: ATLAS-1719 > https://issues.apache.org/jira/browse/ATLAS-1719 > > > Repository: atlas > > > Description > ------- > > Tag association UI should allow users to input value for enum type attributes > from a drop-down. > Ex. For hive_principal_type enum type drop-down should shown > { USER, ROLE, GROUP } > > > Diffs > ----- > > dashboardv2/public/js/templates/tag/addTagModalView_tmpl.html 3b6b429 > dashboardv2/public/js/views/tag/addTagModalView.js 8beec4b > > > Diff: https://reviews.apache.org/r/58343/diff/1/ > > > Testing > ------- > > Verified while Tag associating to entity, UI should allow users to input > value for enum type attributes from a drop-down. > > > Thanks, > > Kalyani Kashikar > >