----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58340/#review171791 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On April 12, 2017, 1:45 p.m., Kalyani Kashikar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58340/ > ----------------------------------------------------------- > > (Updated April 12, 2017, 1:45 p.m.) > > > Review request for atlas, keval bhatt and Madhan Neethiraj. > > > Bugs: ATLAS-1718 > https://issues.apache.org/jira/browse/ATLAS-1718 > > > Repository: atlas > > > Description > ------- > > In Create/update tag UI, attribute datatype should provide enum-types in > drop-down along with built-in types. ( like hive_principal_type, file_action). > > > Diffs > ----- > > dashboardv2/public/js/templates/tag/AddTagAttributeView_tmpl.html f6e1aac > dashboardv2/public/js/templates/tag/createTagLayoutView_tmpl.html 256209b > dashboardv2/public/js/views/tag/AddTagAttributeView.js 3108279 > dashboardv2/public/js/views/tag/CreateTagLayoutView.js 34fa114 > dashboardv2/public/js/views/tag/TagAttributeItemView.js 2482543 > > > Diff: https://reviews.apache.org/r/58340/diff/2/ > > > Testing > ------- > > Verified when creating the tag, attribute datatype drop-down contains the > enum type. > > > Thanks, > > Kalyani Kashikar > >
