> On April 14, 2017, 4:27 a.m., Madhan Neethiraj wrote: > >
I am not sure how Coverity works. If entity is NULL, the assert and test will fail. In _ZipSourceTest_ Coverity flagged NULL reference desipite having this line. _Assert.assertNotNull(creationOrder);_ I can attempt to remove all the _if_ blocks and see if that helps. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57758/#review171986 ----------------------------------------------------------- On April 14, 2017, 2:14 a.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57758/ > ----------------------------------------------------------- > > (Updated April 14, 2017, 2:14 a.m.) > > > Review request for atlas, Madhan Neethiraj and Nixon Rodrigues. > > > Bugs: ATLAS-1735 > https://issues.apache.org/jira/browse/ATLAS-1735 > > > Repository: atlas > > > Description > ------- > > For Unit tests: > - Added _Assert.fail_ after _NULL_ check. > > For _AuthenticationUtils_: > - Added if clause. > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java > b5b00268 > > repository/src/test/java/org/apache/atlas/repository/impexp/ExportServiceTest.java > bac831b7 > > repository/src/test/java/org/apache/atlas/repository/impexp/ZipSourceTest.java > e124ffc4 > > > Diff: https://reviews.apache.org/r/57758/diff/1/ > > > Testing > ------- > > For Unit tests: Ran unit tests. > For AuthenticationUtil: Deployed and tested _quick_start.py_. > Compiled. > > > Thanks, > > Ashutosh Mestry > >
