----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58588/#review172692 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java Line 148 (original), 148 (patched) <https://reviews.apache.org/r/58588/#comment245745> Yes, what you proposed is right. Default search behavior should not have deleted entities unless specified. So we still expose the historical flag as boolean flag in REST, to retrieve all deleted entities? - Sarath Subramanian On April 20, 2017, 12:23 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58588/ > ----------------------------------------------------------- > > (Updated April 20, 2017, 12:23 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Suma Shivaprasad. > > > Bugs: ATLAS-1742 > https://issues.apache.org/jira/browse/ATLAS-1742 > > > Repository: atlas > > > Description > ------- > > Atlas UI needs to be enhanced to enable search on active entities in fulltext > and basic search. This JIRA addresses the backend changes needed to enable > this functionality. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java > 30d62a4b > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > 07190dbf > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 836626b5 > > > Diff: https://reviews.apache.org/r/58588/diff/1/ > > > Testing > ------- > > testing in progress > > > Thanks, > > Sarath Subramanian > >