----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58839/#review173323 -----------------------------------------------------------
dashboardv2/public/js/views/search/SearchResultLayoutView.js Line 234 (original), 235 (patched) <https://reviews.apache.org/r/58839/#comment246340> I am finding the use of deleteChecked as the paramater name confusing. I suggest it would more understandable to have a the flag name as "includeHistorical" then map it to the excludeDeleted API flag at the last moment. "excludeDeleted" a not great naming as it is a double negative already. - David Radley On April 28, 2017, 11:23 a.m., Kalyani Kashikar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58839/ > ----------------------------------------------------------- > > (Updated April 28, 2017, 11:23 a.m.) > > > Review request for atlas, keval bhatt and Madhan Neethiraj. > > > Bugs: ATLAS-1755 > https://issues.apache.org/jira/browse/ATLAS-1755 > > > Repository: atlas > > > Description > ------- > > Add checkbox for basic search to include deleted entities. > > > Diffs > ----- > > dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html > af984f5 > dashboardv2/public/js/views/search/SearchResultLayoutView.js cad4bec > > > Diff: https://reviews.apache.org/r/58839/diff/1/ > > > Testing > ------- > > Verified added checkbox for basic search to include deleted entities. > Verified checkbox is removed for Advance search to show deleted entities . > > > Thanks, > > Kalyani Kashikar > >
