----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58868/#review173412 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java Line 212 (original), 210 (patched) <https://reviews.apache.org/r/58868/#comment246420> when attrName is specified and if no attribute is found, then this should be flagged as an error condition, just as in earlier implementation - with: if (attribute == null) { throw new AtlasBaseException(AtlasErrorCode.UNKNOWN_ATTRIBUTE, attrName, typeName); } With the current change, this condition will assume search by guid - like #222 repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java Lines 234 (patched) <https://reviews.apache.org/r/58868/#comment246421> Consider moving lines #234 - #236 in the else block above at #228. repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java Lines 274 (patched) <https://reviews.apache.org/r/58868/#comment246418> This debug log will be printed for each entry in the search result. Perphas you mean this to be outside the while() loop? - Madhan Neethiraj On April 29, 2017, 12:36 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58868/ > ----------------------------------------------------------- > > (Updated April 29, 2017, 12:36 a.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Suma Shivaprasad. > > > Bugs: ATLAS-1761 > https://issues.apache.org/jira/browse/ATLAS-1761 > > > Repository: atlas > > > Description > ------- > > Improve attribute search to enable search based on display text and guid > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > 07190dbf > > repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java > d3413c23 > > repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java > 633fad03 > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 76ad88cb > > > Diff: https://reviews.apache.org/r/58868/diff/1/ > > > Testing > ------- > > Tsted using POSTMAN client. > > > Thanks, > > Sarath Subramanian > >
