----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58746/ -----------------------------------------------------------
(Updated May 1, 2017, 7:36 p.m.) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad. Changes ------- Updated description and addressed review comments. Summary (updated) ----------------- Type validations with special character handling Bugs: ATLAS-1730, ATLAS-1736 and ATLAS-1747 https://issues.apache.org/jira/browse/ATLAS-1730 https://issues.apache.org/jira/browse/ATLAS-1736 https://issues.apache.org/jira/browse/ATLAS-1747 Repository: atlas Description (updated) ------- 1. Added empty attribute(s) check 2. Dealing with special characters like $,%,{,} (titan treats these specially) 3. Update of attribute type is not allowed anymore Diffs (updated) ----- repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 6f1b80c8 repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 7037d1eb repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java c08bb881 Diff: https://reviews.apache.org/r/58746/diff/3/ Changes: https://reviews.apache.org/r/58746/diff/2-3/ Testing ------- mvn clean package executes successfully Thanks, Apoorv Naik