-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60204/
-----------------------------------------------------------
(Updated June 21, 2017, 3:10 a.m.)
Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
Changes
-------
Updates include:
- ZipSource JSON serialization now uses _AtlasType.fromJSON_
- _ObjectMapper_ in _AtlasType_ now configured to handle large floats & doubles.
Bugs: ATLAS-1876
https://issues.apache.org/jira/browse/ATLAS-1876
Repository: atlas
Description
-------
**Background**
Refer to ATLAS-1876 for details. Please see the modified steps in comments
section.
**Root Cause**
_AtlasBuiltInTypes_ do not validate the incoming types using the range check
for the primitive types. This causes out of range _float_ and _double_ values
to be passed as valid even when they are holding _Infinity_.
While the attribute value assignment goes through within the code, subsequent
operations fail as the correct values are not present in the database.
**Fix**
Range check added for _float_ and _double_.
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java f08a6015
intg/src/main/java/org/apache/atlas/type/AtlasType.java f05cfd61
intg/src/test/java/org/apache/atlas/type/TestAtlasBuiltInTypesFloatDouble.java
PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/impexp/ZipSource.java
aa1477f1
repository/src/test/java/org/apache/atlas/repository/impexp/ZipSourceTest.java
8a57dcd8
repository/src/test/resources/stocks-float.zip PRE-CREATION
Diff: https://reviews.apache.org/r/60204/diff/3/
Changes: https://reviews.apache.org/r/60204/diff/2-3/
Testing
-------
**Unit tests**
- New unit tests added for _AtlasFloatType_ and _AtlasDoubleType_.
- Verified all existing unit tests.
**Functional tests**
- Validation verified by following steps mentioned in JIRA. Validation error is
returned instead of successful operation.
Thanks,
Ashutosh Mestry
