----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16054/#review30131 -----------------------------------------------------------
src/main/java/com/twitter/aurora/scheduler/Driver.java <https://reviews.apache.org/r/16054/#comment57692> Mind adjusting the comments here to reflect run/start change? src/main/java/com/twitter/aurora/scheduler/ForwardingSchedulerDriver.java <https://reviews.apache.org/r/16054/#comment57693> Reword to reduce "implementation" count? src/main/java/com/twitter/aurora/scheduler/ForwardingSchedulerDriver.java <https://reviews.apache.org/r/16054/#comment57695> I don't see where this class is used. Also, looks like a very thin proxy not adding anything immediately useful. src/main/java/com/twitter/aurora/scheduler/ForwardingSchedulerDriver.java <https://reviews.apache.org/r/16054/#comment57694> Did you mean start() here? src/main/java/com/twitter/aurora/scheduler/SchedulerLifecycle.java <https://reviews.apache.org/r/16054/#comment57699> Nice! It could be much easier now to add RESTORING state when we get to restore from backup. src/main/java/com/twitter/aurora/scheduler/SchedulerLifecycle.java <https://reviews.apache.org/r/16054/#comment57697> Would ANNOUNCED_REGISTERED_LEADER be the "normal" state of the running scheduler? If so, how about having a dedicated "RUNNING" state to better communicate scheduler state in the logs and possibly UI? src/main/java/com/twitter/aurora/scheduler/SchedulerLifecycle.java <https://reviews.apache.org/r/16054/#comment57716> Should it rather be a timed join? From the SchedulerDriver specs it looks like it's an indefinite wait on mesos side. - Maxim Khutornenko On Dec. 9, 2013, 8:11 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16054/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2013, 8:11 p.m.) > > > Review request for Aurora, Kevin Sweeney and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > This change addresses two issues: > - Ensure leadership is canceled whenever onDefeated is called > - Scheduler should wait for registered to be called before attempting to > invoke driver > > Some additional structural changes were made: > - Driver.run() is no longer used. Instead, we invoke Driver.start() > (non-blocking), and the lifecycle uses Driver.join() to await exit. > This allows us to avoid jumping through thread-safety hoops in unit tests. > - A shim interface (DelayedActions) was added to SchedulerLifecycle to make > testing easier when capturing delayed closures. > > > Diffs > ----- > > src/main/java/com/twitter/aurora/scheduler/Driver.java > e8fe170b2d9e1a752b152cedc0e006f10eaa5a11 > src/main/java/com/twitter/aurora/scheduler/ForwardingSchedulerDriver.java > PRE-CREATION > src/main/java/com/twitter/aurora/scheduler/SchedulerLifecycle.java > 346d52acc5fc9e4841e2dc8b424fc6d46d2cdc8c > src/main/java/com/twitter/aurora/scheduler/SchedulerModule.java > bd7929d631cf45b4c2c7f39177bbafbd8f659071 > src/main/java/com/twitter/aurora/scheduler/app/SchedulerMain.java > 73b86a9f99cb1931ccce1db0baf7c6f56ba0b65d > > src/main/java/com/twitter/aurora/scheduler/storage/testing/StorageTestUtil.java > ceef9d3bd4b43d2dcac0ab9129ae2b624ab654cf > src/test/java/com/twitter/aurora/scheduler/DriverTest.java > 5609b0b8b9a26a737558316e8e4fab0235704cb8 > src/test/java/com/twitter/aurora/scheduler/SchedulerLifecycleTest.java > PRE-CREATION > src/test/java/com/twitter/aurora/scheduler/app/SchedulerIT.java > 4c381b946c8a3c7bbe1757d384d5d43dd74bb4d0 > > Diff: https://reviews.apache.org/r/16054/diff/ > > > Testing > ------- > > gradle clean build > > > Thanks, > > Bill Farner > >
