> On Dec. 12, 2013, 5:07 p.m., Bill Farner wrote: > > src/main/java/com/twitter/aurora/scheduler/http/Maintenance.java, line 64 > > <https://reviews.apache.org/r/16220/diff/6/?file=397095#file397095line64> > > > > At this point, you might as well just return Response from the storage > > op
done. > On Dec. 12, 2013, 5:07 p.m., Bill Farner wrote: > > src/main/java/com/twitter/aurora/scheduler/http/Maintenance.java, line 84 > > <https://reviews.apache.org/r/16220/diff/6/?file=397095#file397095line84> > > > > This is probably more appropriately-named getTasksByHosts() done. > On Dec. 12, 2013, 5:07 p.m., Bill Farner wrote: > > src/main/java/com/twitter/aurora/scheduler/http/Maintenance.java, line 87 > > <https://reviews.apache.org/r/16220/diff/6/?file=397095#file397095line87> > > > > (1) please leave a blank line between a wrapped method signature and > > the method body > > (2) indentation is funky in this method done. > On Dec. 12, 2013, 5:07 p.m., Bill Farner wrote: > > src/main/java/com/twitter/aurora/scheduler/state/MaintenanceController.java, > > line 213 > > <https://reviews.apache.org/r/16220/diff/6/?file=397096#file397096line213> > > > > I would find this more concise and more readable: > > > > if (attributes.isPresent() && (DRAINING == attributes.getMode())) { > > ... > > } done. > On Dec. 12, 2013, 5:07 p.m., Bill Farner wrote: > > src/main/java/com/twitter/aurora/scheduler/state/MaintenanceController.java, > > line 217 > > <https://reviews.apache.org/r/16220/diff/6/?file=397096#file397096line217> > > > > inline below done. > On Dec. 12, 2013, 5:07 p.m., Bill Farner wrote: > > src/main/java/com/twitter/aurora/scheduler/state/MaintenanceController.java, > > line 291 > > <https://reviews.apache.org/r/16220/diff/6/?file=397096#file397096line291> > > > > please kindly give intellij a smack and revert done. - Zameer ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16220/#review30316 ----------------------------------------------------------- On Dec. 12, 2013, 4:56 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16220/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2013, 4:56 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-9 > https://issues.apache.org/jira/browse/AURORA-9 > > > Repository: aurora > > > Description > ------- > > Improve the /maintenance endpoint to print out hosts affected by SCHEDULED > and DRAINED states. > > > Diffs > ----- > > src/main/java/com/twitter/aurora/scheduler/http/Maintenance.java > 30afce37d6c108a5a8c1c3c8a8094030ad12ce72 > src/main/java/com/twitter/aurora/scheduler/state/MaintenanceController.java > fb12d38858b260d1d9ce318d3022cd93413a3e68 > > src/test/java/com/twitter/aurora/scheduler/state/MaintenanceControllerImplTest.java > 8acb716c733ec9d3cc3b1ec74c85f958082ae139 > > Diff: https://reviews.apache.org/r/16220/diff/ > > > Testing > ------- > > ./gradlew clean build > > > Thanks, > > Zameer Manji > >
