> On Dec. 11, 2013, 1:59 a.m., Bill Farner wrote: > > src/main/java/com/twitter/aurora/scheduler/app/SchedulerMain.java, line 141 > > <https://reviews.apache.org/r/16163/diff/1/?file=396257#file396257line141> > > > > please drop QUOTA from here, as i'm pulling that out in a separate > > review
I was planning to merge later, but since I have to move repos anyways, did it now. Done. > On Dec. 11, 2013, 1:59 a.m., Bill Farner wrote: > > src/main/java/com/twitter/aurora/scheduler/app/Modules.java, line 1 > > <https://reviews.apache.org/r/16163/diff/1/?file=396256#file396256line1> > > > > please add license header. i suggest you go ahead and configure > > intellij to fill it in for you (search for 'template' in the preferences > > search bar). Done. Thanks. - Suman ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16163/#review30169 ----------------------------------------------------------- On Dec. 10, 2013, 8:48 p.m., Suman Karumuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16163/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2013, 8:48 p.m.) > > > Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Added extra_modules option to Scheduler. > > Already have ship it on this in the internal repo. Sending it for review > again to check it in. > > > Diffs > ----- > > src/main/java/com/twitter/aurora/scheduler/app/Modules.java PRE-CREATION > src/main/java/com/twitter/aurora/scheduler/app/SchedulerMain.java > 73b86a9f99cb1931ccce1db0baf7c6f56ba0b65d > > Diff: https://reviews.apache.org/r/16163/diff/ > > > Testing > ------- > > gradle clean build. > > > Thanks, > > Suman Karumuri > >
