Leo,
I thought I'd draw some more attention to this as it seems like this might be a contentious issue and it should not be in the way of a 4.1.4 release (ie if this turns out to be contentious I'll remove the class again for now).The class is fine, but let us not market it as Commons logging in Avalon-Framework. This is what /they/ want :-
I just wrote and committed a single class, org.apache.avalon.framework.logger.CommonsLogger, which implements Logger by (trivially) wrapping around commons-logging. I also added in proper conditionals in the build so that things build properly if commons-logging is not available.
Like all code, it is subject to a lazy consensus vote. If you don't want CommonsLogger in 4.1.4 (despite the sound arguments below :D), please say so ASAP so any discussion isn't in the way of a 4.1.4 release. I don't want to steamroll this in.
public class Foo {
private static final Log logger = LogFactory.getLog(Foo.class);
// other methods static {
logger.info("yee haaa");
}
}
We have not engineered a solution, just a delegate that is instance orientated :-
public Foo implements LogEnabled {
Logger logger;
pubic void enableLogging(Logger logger) {
this.logger = logger;
}
static {
// whoops can't do logging here.
}
}
So -1 .. it adds nothing that we did not have already.
- PH
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
