[ 
https://issues.apache.org/jira/browse/AVRO-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Zeyliger updated AVRO-670:
---------------------------------

          Status: Resolved  (was: Patch Available)
    Hadoop Flags: [Incompatible change, Reviewed]
    Release Note: The "fromjson" tool now requires either a --schema or 
--schema-file command-line argument to specify the schema.  Previously, the 
schema was to be specified as the first argument.
        Assignee: Ron Bodkin
      Resolution: Fixed

Hi Ron,

Thanks for your contribution!  (And congratulations on your first contribution 
to AVRO.)  I've committed it.

I made two very minor changes:

I fixed one "checkstyle" bug ("ant test" runs checkstyle) 

bq. [checkstyle] 
/data/6/philip/avro-svn/lang/java/src/java/org/apache/avro/tool/DataFileWriteTool.java:121:69:
 Redundant throws: 'FileNotFoundException' is subclass of 'IOException'.

I also added a "--schema" to src/test/bin/test_tools.sh in one place, to fix a 
test failure.

> Allow DataFileWriteTool to accept schema files as input
> -------------------------------------------------------
>
>                 Key: AVRO-670
>                 URL: https://issues.apache.org/jira/browse/AVRO-670
>             Project: Avro
>          Issue Type: Improvement
>            Reporter: Ron Bodkin
>            Assignee: Ron Bodkin
>             Fix For: 1.5.0
>
>         Attachments: AVRO-670.patch, datafilewritefile.patch
>
>
> For non-trivial schemas, it's difficult to pass them inline as a command line 
> argument. I made a patch to use two different arguments: instead of having 
> the first argument be the schema you would now use -schema-file file or 
> -schema schema and then have one other argument (the input JSON file)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to