[ 
https://issues.apache.org/jira/browse/AVRO-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Cutting updated AVRO-723:
------------------------------

    Attachment: AVRO-723.patch

Here's a new version of the patch where the exception is caught in the 
Responder base class rather than both in SpecificResponder and 
GenericResponder.  I also removed some spurious changes to imports present in 
your patch.

If this looks reasonable, I'll commit it.


> Incorrect handling of Undeclared Errors in IPC calls to SpecificResponder
> -------------------------------------------------------------------------
>
>                 Key: AVRO-723
>                 URL: https://issues.apache.org/jira/browse/AVRO-723
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.5.0
>            Reporter: Stephen Gargan
>            Priority: Minor
>             Fix For: 1.5.0
>
>         Attachments: AVRO-723.patch, undeclared-error.patch, 
> undeclared-error.patch, undeclared-error.patch
>
>
> Undeclared errors thrown during service invocations are not getting returned 
> correctly. When they are encountered, the writeError method in the responder 
> will try to encode them using errors union for the message. However, because 
> they are undeclared they are not present in the union and encoding causes a 
> further AvroRuntimeException. Its this "Not in union" exception that gets 
> returned to the client, not the undeclared problem which gets lost.
> The attached patch handles them like other system errors, calling to string 
> on the exception and writing this as the error to be returned.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to