[ 
https://issues.apache.org/jira/browse/AVRO-784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009251#comment-13009251
 ] 

E. Sammer commented on AVRO-784:
--------------------------------

Scott:

{quote}
In the long run we'll end up with a few variations for generated code. One of 
them will nee to be 'standard' bean compatible, with set/get prefixes because 
other frameworks look for that.

In general, the user should have a choice on how to generate the access 
methods. However, the first iteration does not need to be that flexible, as 
long as it doesn't cause difficulty implementing other variations in the future.
{quote}

+1. Makes sense to me. I also like your point on nullable types. That's a nice 
(and easy) thing to expose like that.

I think having field level flexibility is a good long term goal and will be 
useful. Support for advanced annotations like @immutable and @builder (at the 
record level) are very cool.

I guess my current question is, assuming I can brow beat Doug sufficiently, 
what subset of these features are required as a v1 feature set? In addition to 
what I have, I'm confident I can handle:

* Making the changes Doug suggested (e.g. doc addition / generation, removing 
use of put() / get(), dealing with the boxing appropriately).
* Generating accessors that support ref types for nullable and primitives for 
non-nullables (assuming that information is easy to get at from Schema$Field or 
friends).

I haven't yet looked at what it takes to implement annotations. For that 
reason, I'm inclined to defer that to another JIRA if that's acceptable 
(although I'd still be interested in doing it).

> SpecificCompiler should generate accessors
> ------------------------------------------
>
>                 Key: AVRO-784
>                 URL: https://issues.apache.org/jira/browse/AVRO-784
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.5.0
>            Reporter: E. Sammer
>              Labels: features
>         Attachments: avro-784.diff
>
>
> Avro's Java SpecificCompiler should generate java bean style accessors.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to