[ https://issues.apache.org/jira/browse/AVRO-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180661#comment-13180661 ]
Scott Carey commented on AVRO-987: ---------------------------------- Quick comments: * The code changes visible look good. * The ClassLoadingUtils.java file does not seem to be in the patch * The pom.xml changes suggest that OSGi (or this plugin) requires repeating the maven dependency information again, which is a maintenance burden and potential source of future issues. If we must do this, I would like to see this repeated informatoin as close to the duplicate info (dependency section) as possible, and have a comment describing why it is there and how to maintain it for those that are not familiar with OSGi or the plugin. * Perhaps we should consider a tool that breaks the bulid (checkstyle?) if Class.forName() is used outside of the util class. > Make Avro OSGi ready > -------------------- > > Key: AVRO-987 > URL: https://issues.apache.org/jira/browse/AVRO-987 > Project: Avro > Issue Type: New Feature > Components: java > Reporter: Ioannis Canellos > Attachments: AVRO-987-patch.txt > > > It would be really nice to be able to use Avro inside OSGi. To achieve this > two things are required: > i) Provide proper MANIFEST.MF. > ii) Deal with potential class loading issues. Avro uses Class.forName a lot > and that is not very OSGi friendly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira