[
https://issues.apache.org/jira/browse/AVRO-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187354#comment-13187354
]
Scott Carey commented on AVRO-993:
----------------------------------
Looks good. My only nit is to have the javadoc link to the actual replacement
method.
for example:
{noformat}
/**
* Called to create an fixed value. May be overridden for alternate fixed
* representations. By default, returns {@link GenericFixed}.
* @deprecated As of Avro 1.6.0 this method has been moved to
* {@link GenericData#createFixed(Object, byte[], Schema)}
*/
{noformat}
> Add methods back to GenericDatumReader that were removed in AVRO-839
> --------------------------------------------------------------------
>
> Key: AVRO-993
> URL: https://issues.apache.org/jira/browse/AVRO-993
> Project: Avro
> Issue Type: Bug
> Affects Versions: 1.6.0, 1.6.1
> Reporter: James Baldassari
> Assignee: James Baldassari
> Attachments: AVRO-993.patch
>
>
> As part of AVRO-839 three methods were moved from GenericDatumReader to
> GenericData:
> * newRecord(Object, Schema)
> * createFixed(Object old, Schema schema)
> * createFixed(Object, byte[], Schema)
> Although their visibility is protected, they are part of the public API
> because GenericDatumReader is public. Therefore these methods should have
> been deprecated before being removed. The removal of these methods caused
> PIG-2463.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
