[ 
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13603884#comment-13603884
 ] 

Doug Cutting commented on AVRO-1274:
------------------------------------

Some nits:
 - If a default value has a nested bytes then it will fail.  For example, a 
field whose type is a record with a field named 'a' of type bytes can have a 
default value of {"a":"asdf"}, but GenericData.toString() won't generate this 
correctly.  I think this can just remain a "known issue" until we fix 
GenericData.toString(), but we should probably add a comment noting that.
 - Is SchemaParseException the right exception here?  AvroRuntimeException or 
perhaps some new exception like SchemaBuilderError or somesuch.

Other than that, this looks great!  +1

                
> Add a schema builder API
> ------------------------
>
>                 Key: AVRO-1274
>                 URL: https://issues.apache.org/jira/browse/AVRO-1274
>             Project: Avro
>          Issue Type: New Feature
>          Components: java
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: AVRO-1274.patch, AVRO-1274.patch, AVRO-1274.patch, 
> AVRO-1274.patch, TestDefaults.patch
>
>
> It would be nice to have a fluent API that made it easier to construct record 
> schemas.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to