[ 
https://issues.apache.org/jira/browse/AVRO-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13851668#comment-13851668
 ] 

Douglas Creager commented on AVRO-1405:
---------------------------------------

Hi Mika,

You're right that there's no explicit style or build guide for the C bindings.  
That should be on our task list to write one.  I've been following a basic rule 
of “make any new code look like the old code”.  As far as C standards, the 
`build.sh` script is what Doug Cutting uses to cut releases, and what the 
buildbots use to run automated tests, so you can see (by digging a bit, 
admittedly) which GCC flags we pass in.  Nothing to turn on full C99 
compliance, and we turn on `-W -Wall` to see extra warning messages.  Again, 
you're absolutely right that we should be more explicit in this, but hopefully 
that helps clear things up a bit.

I'm going through the C issue backlog right now, so I'll go ahead and push up a 
new patch with a test case that doesn't throw the warnings.

> Avro-c may not handle eof correctly if avro data file contains multiple sync 
> markers
> ------------------------------------------------------------------------------------
>
>                 Key: AVRO-1405
>                 URL: https://issues.apache.org/jira/browse/AVRO-1405
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.7.5
>            Reporter: Mika Ristimaki
>            Assignee: Mika Ristimaki
>            Priority: Minor
>             Fix For: 1.7.6
>
>         Attachments: AVRO-1405.patch
>
>
> I encountered a bug in the Avro C API. If the following is done, it seems 
> that the Avro data file reader can not read the file correctly
> {code}
> while (has values to write) {
>       Open file for writing
>       Write a value to the file
>       Close the writer
> }
> {code}
> Reading this file with Avro data file reader fails with EOF after only the 
> first item has been read from the file.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to