[ 
https://issues.apache.org/jira/browse/AVRO-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Cutting updated AVRO-1442:
-------------------------------

    Attachment: AVRO-1442.patch

Thanks for providing the fix & a test.  We prefer patches as files attached to 
the issue (see the "More" menu, above).  Here's a patch file that includes your 
change and test.  I renamed the test so that it doesn't refer to the bug 
number, as is our style.

I'll commit this soon unless someone objects.

> Case "FIXED" not handled in ResolvingGrammarGenerator
> -----------------------------------------------------
>
>                 Key: AVRO-1442
>                 URL: https://issues.apache.org/jira/browse/AVRO-1442
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.7.6
>            Reporter: Jim Pivarski
>              Labels: exceptions
>             Fix For: 1.7.7
>
>         Attachments: AVRO-1442.patch
>
>
> Symptom: Attempts to match reader = FIXED against writer != FIXED results in 
> a RuntimeException ("Unexpected schema type: FIXED"), rather than an 
> appropriate Symbol.ErrorAction.
> Reason: In the ResolvingGrammarGenerator.generate method, there are two 
> switch statements, one for writerType == readerType and the other for 
> writerType != readerType.  In the latter, "case FIXED:" is missing.
> This is true in the GitHub version (HEAD?) as well: 
> https://github.com/apache/avro/blob/branch-1.3/lang/java/src/java/org/apache/avro/io/parsing/ResolvingGrammarGenerator.java#L155



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to