[ 
https://issues.apache.org/jira/browse/AVRO-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529733#comment-15529733
 ] 

Niels Basjes commented on AVRO-1923:
------------------------------------

Yes, that is better (see updated pull request). 

One thing I left out is removing it in a finally block.
It is an operation that I think is not needed (at the end of the toString the 
entire Map is discarded anyway).
Why do you do it?
Is it needed?


> Recursive record causes StackOverflow in GenericData.toString
> -------------------------------------------------------------
>
>                 Key: AVRO-1923
>                 URL: https://issues.apache.org/jira/browse/AVRO-1923
>             Project: Avro
>          Issue Type: Bug
>            Reporter: Niels Basjes
>            Assignee: Niels Basjes
>         Attachments: AVRO-1923-Unittest.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to