[ 
https://issues.apache.org/jira/browse/AVRO-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15787961#comment-15787961
 ] 

ASF GitHub Bot commented on AVRO-1973:
--------------------------------------

GitHub user gszadovszky opened a pull request:

    https://github.com/apache/avro/pull/178

    AVRO-1973: Upgrade netty to the latest 3.x release

    Upgrading netty version to `3.10.6` caused a test failure. The root cause 
was that from `3.6.0` netty does not interrupt worker threads therefore, 
`server2.close()` would hang until `blockingSimpleImpl.releaseRunPermit()` is 
invoked. Could not find any way to call an interrupt on the related workers 
therefore, modified the test.
    
    Also fixed an issue in the same test that an assert would never fail a test 
if simply invoked in another thread. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gszadovszky/avro AVRO-1973

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/avro/pull/178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #178
    
----
commit 3597d8e9f8b0036451fe1589da578b03a5639e58
Author: Gabor Szadovszky <gabor.szadovs...@cloudera.com>
Date:   2016-12-30T16:27:00Z

    AVRO-1973: Upgrade netty to the latest 3.x release

----


> Upgrade netty to the latest 3.x release
> ---------------------------------------
>
>                 Key: AVRO-1973
>                 URL: https://issues.apache.org/jira/browse/AVRO-1973
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.8.1
>            Reporter: Gabor Szadovszky
>            Assignee: Gabor Szadovszky
>
> Netty version {{3.5.13}} is pretty old. Shall be updated to the latest 3.x 
> release: {{3.10.6}}. 
> (Not suggesting to upgrade to 4.x as it requires much more effort due to API 
> incompatibilities.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to