[
https://issues.apache.org/jira/browse/AVRO-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421704#comment-16421704
]
ASF GitHub Bot commented on AVRO-1702:
--------------------------------------
thiru-apache commented on a change in pull request #302: AVRO-1702: Added
support for logical types in the C++ client.
URL: https://github.com/apache/avro/pull/302#discussion_r178461909
##########
File path: lang/c++/api/GenericDatum.hh
##########
@@ -54,12 +55,15 @@ namespace avro {
*/
class AVRO_DECL GenericDatum {
Type type_;
+ LogicalType logicalType_;
boost::any value_;
- GenericDatum(Type t) : type_(t) { }
+ GenericDatum(Type t, LogicalType logicalType)
Review comment:
In order to avoid backward incompatibility, it will be better to continue to
have the old constructor, (in addition to the new constructor):
GenericDatum(Type t) : type_(t, logicalType(LogicalType::NONE)) { }
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add LogicalType support to c++ library
> --------------------------------------
>
> Key: AVRO-1702
> URL: https://issues.apache.org/jira/browse/AVRO-1702
> Project: Avro
> Issue Type: New Feature
> Components: c++
> Reporter: peter liu
> Assignee: peter liu
> Priority: Major
>
> I'd like to port the logicaltype support to c++ library
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
