[
https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640225#comment-16640225
]
ASF GitHub Bot commented on AVRO-2229:
--------------------------------------
kojiromike commented on a change in pull request #343: [AVRO-2229] Test using a
Docker image
URL: https://github.com/apache/avro/pull/343#discussion_r223110882
##########
File path: build.sh
##########
@@ -26,6 +26,12 @@ function usage {
exit 1
}
+headline(){
+ echo -e
"\e[1;34m#################################################################"
+ echo -e "##### $1 \e[1;37m"
+ echo -e
"\e[1;34m#################################################################\e[0m"
Review comment:
Can't remember if I commented on this in the previous PR, but can the ansi
escapes here be handled using e.g. tput, or otherwise avoid breaking dumb
terminals?
```bash
termblack=$(tput setaf 0)
termred=$(tput setaf 1)
termgreen=$(tput setaf 2)
termyellow=$(tput setaf 3)
termblue=$(tput setaf 4)
termpurple=$(tput setaf 5)
termaqua=$(tput setaf 6)
termreset=$(tput sgr0)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Ability to test using a Docker image
> ------------------------------------
>
> Key: AVRO-2229
> URL: https://issues.apache.org/jira/browse/AVRO-2229
> Project: Avro
> Issue Type: Improvement
> Affects Versions: 1.8.2
> Reporter: Fokko Driesprong
> Assignee: Fokko Driesprong
> Priority: Major
> Fix For: 1.9.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
