[ https://issues.apache.org/jira/browse/AVRO-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683767#comment-16683767 ]
ASF subversion and git services commented on AVRO-1256: ------------------------------------------------------- Commit 4a8e814327be1f18b203784778f8b17d7f9da8b0 in avro's branch refs/heads/master from [~aniket486] [ https://gitbox.apache.org/repos/asf?p=avro.git;h=4a8e814 ] AVRO-1256: C++ API compileJsonSchema ignores "doc" and custom attributes on a field/record (#345) * AVRO-1256. C++ API compileJsonSchema ignores doc and custom attributes on a field/record * minor code fixes * minor code fixes * more std::string fixes * Add escape_json function to print doc string * solve merge conflict * compactSchema changes * minor refactor * Fix tests * fix formatting * fix formatting * Fix nullptr and tests > C++ API compileJsonSchema ignores "doc" and custom attributes on a > field/record > ------------------------------------------------------------------------------- > > Key: AVRO-1256 > URL: https://issues.apache.org/jira/browse/AVRO-1256 > Project: Apache Avro > Issue Type: Improvement > Components: c++ > Affects Versions: 1.7.2 > Environment: Running on all platforms (Windows, OSX, Linux) > Reporter: Tim Menninger > Assignee: Aniket Mokashi > Priority: Minor > Attachments: AVRO-1256.patch > > > It appears that when my JSON is compiled into a valid schema object it is > ignoring all types of "documentation" that I am trying to adorn with each > field in my record. Reading through the Java issues it seems that this was a > bug and fixed (AVRO-601, AVRO-612, AVRO-779) but it seems the C++ > implementation has yet to adopt this feature? This is my sample schema, I > have attempted to insert both "doc" and "mycustom" in multiple places to see > if it is supported at any level. Please excuse if there appears to be a > syntax error in the JSON I hand tweaked some of this. The schema is valid and > successfully parses. > { > "type": "record", > "name": "myschema", > "doc": "Doc Meta", > "mycustom": "My Custom", > "fields": [ > { "name":"field_a","type":["string","null"], "doc":"Doc Meta", > "mycustom":"My Custom A"}, > { "name":"field_b","type":["string","null"], "doc":"Doc Meta", > "mycustom":"My Custom B"}, > { "name":"field_c","type":["string","null"], "doc":"Doc Meta", > "mycustom":"My Custom C"} > ] > } > I looked through the SchemaTests.cc code for 1.7.3 and there was not a test > case for this there so i didn't think this was addressed in that version. I > am running 1.7.2. When this schema is used to load with compileJsonSchema and > then a file is serialized the file schema looks like this. > { > "type":"record", > "name":"myschema", > "fields": [ > { "name":"field_a","type":["string","null"]}, > { "name":"field_b","type":["string","null"]}, > { "name":"field_c","type":["string","null"]} > ] > } -- This message was sent by Atlassian JIRA (v7.6.3#76005)