[
https://issues.apache.org/jira/browse/AVRO-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684182#comment-16684182
]
ASF GitHub Bot commented on AVRO-2262:
--------------------------------------
jacobtolar commented on issue #352: AVRO-2262 Java compression codec
improvements
URL: https://github.com/apache/avro/pull/352#issuecomment-437975579
Sorry, I hadn't gotten back around to this yet. Thanks for merging.
I'll have to send a separate PR with the unit test I was going to add to
this branch once #351 was merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Java compression codec improvements
> -----------------------------------
>
> Key: AVRO-2262
> URL: https://issues.apache.org/jira/browse/AVRO-2262
> Project: Apache Avro
> Issue Type: Task
> Components: java
> Affects Versions: 1.8.2
> Reporter: Fokko Driesprong
> Assignee: Jacob Tolar
> Priority: Major
> Fix For: 1.9.0
>
>
> * Update a few things to use try-with-resources
> * Updated CodecFactory to reference constants for codec names
> * Fixed a small bug in Snappy and BZip2: compression/decompression were
> incorrect if the input ByteBuffer was a a slice(). I don't see anywhere that
> this would actually happen currently, but some codecs were written to account
> for this correctly; now they're all correct. Updated everything to compute
> the correct offset into the underlying array. (I can add a test for this in
> TestAllCodecs once #351 is merged).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
