[ 
https://issues.apache.org/jira/browse/AVRO-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688578#comment-16688578
 ] 

ASF GitHub Bot commented on AVRO-2239:
--------------------------------------

tjwp opened a new pull request #381: AVRO-2239: Fix RPC interop tests for Ruby
URL: https://github.com/apache/avro/pull/381
 
 
   This fixes https://issues.apache.org/jira/browse/AVRO-2239 and re-enables 
RPC interop tests for Ruby.
   
   The fix is to check that a datum is a Ruby Hash before validating it as a 
map.
   
   The fix for this was already in https://github.com/apache/avro/pull/230, but 
I can rebase that PR if this makes it to master first.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Fix interop tests
> -----------------
>
>                 Key: AVRO-2239
>                 URL: https://issues.apache.org/jira/browse/AVRO-2239
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: interop
>            Reporter: Fokko Driesprong
>            Assignee: Tim Perkins
>            Priority: Major
>
> Currently the interop tests are failing:
> /avro/lang/ruby/lib/avro/schema_validator.rb:127:in `validate_map': undefined 
> method `keys' for nil:NilClass (NoMethodError)
>       from /avro/lang/ruby/lib/avro/schema_validator.rb:103:in 
> `validate_recursive'
>       from /avro/lang/ruby/lib/avro/schema_validator.rb:156:in `block in 
> validate_possible_types'
>       from /avro/lang/ruby/lib/avro/schema_validator.rb:154:in `map'
>       from /avro/lang/ruby/lib/avro/schema_validator.rb:154:in 
> `validate_possible_types'
>       from /avro/lang/ruby/lib/avro/schema_validator.rb:141:in 
> `validate_union'
>       from /avro/lang/ruby/lib/avro/schema_validator.rb:105:in 
> `validate_recursive'
>       from /avro/lang/ruby/lib/avro/schema_validator.rb:110:in `block in 
> validate_recursive'
>       from /avro/lang/ruby/lib/avro/schema_validator.rb:108:in `each'
>       from /avro/lang/ruby/lib/avro/schema_validator.rb:108:in 
> `validate_recursive'
>       from /avro/lang/ruby/lib/avro/schema_validator.rb:67:in `validate!'
>       from /avro/lang/ruby/lib/avro/schema.rb:97:in `validate'
>       from /avro/lang/ruby/lib/avro/io.rb:503:in `write_data'
>       from /avro/lang/ruby/lib/avro/io.rb:499:in `write'
>       from /avro/lang/ruby/lib/avro/ipc.rb:136:in `write_handshake_request'
>       from /avro/lang/ruby/lib/avro/ipc.rb:105:in `request'
>       from lang/ruby/test/tool.rb:69:in `send_message'
>       from lang/ruby/test/tool.rb:137:in `main'
>       from lang/ruby/test/tool.rb:143:in `<main>'



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to