[
https://issues.apache.org/jira/browse/AVRO-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700151#comment-16700151
]
ASF GitHub Bot commented on AVRO-2181:
--------------------------------------
iemejia closed pull request #312: AVRO-2181: missing escape character added
URL: https://github.com/apache/avro/pull/312
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/lang/java/compiler/src/test/java/org/apache/avro/compiler/idl/TestIdl.java
b/lang/java/compiler/src/test/java/org/apache/avro/compiler/idl/TestIdl.java
index b38714410..26e502c1a 100644
--- a/lang/java/compiler/src/test/java/org/apache/avro/compiler/idl/TestIdl.java
+++ b/lang/java/compiler/src/test/java/org/apache/avro/compiler/idl/TestIdl.java
@@ -152,7 +152,7 @@ public String testName() {
public void run() throws Exception {
String output = generate();
String slurped = slurp(expectedOut);
- assertEquals(slurped.trim(), output.replace("\r", "").trim());
+ assertEquals(slurped.trim(), output.replace("\\r", "").trim());
}
public void write() throws Exception {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Missing escape charater in TestIdl.java
> ---------------------------------------
>
> Key: AVRO-2181
> URL: https://issues.apache.org/jira/browse/AVRO-2181
> Project: Apache Avro
> Issue Type: Bug
> Components: build, java
> Affects Versions: 1.8.2
> Environment: Windows
> Reporter: Hans-Peter Werner
> Priority: Major
> Fix For: 1.9.0
>
>
> In a call to String.replace() a backslash is missing before "\r", so CRs are
> not correctly removed in windows environments.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
