[
https://issues.apache.org/jira/browse/AVRO-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976460#comment-16976460
]
Ryan Skraba commented on AVRO-2632:
-----------------------------------
PR#719 _should_ be safe and fix the build, regardless of whether or not we
"unbump" jackson in {{branch-1.9}}. AFAICT, there's no downside to merging it,
except we'll start getting some deprecated warnings in the branch build -- the
method in question {{JsonStringEncoder#getInstance}} was [deprecated in Jackson
2.9|https://fasterxml.github.io/jackson-core/javadoc/2.9/index.html?com/fasterxml/jackson/core/io/JsonStringEncoder.html]
and ["undeprecated" in Jackson
2.10|https://fasterxml.github.io/jackson-core/javadoc/2.10/com/fasterxml/jackson/core/io/JsonStringEncoder.html#getInstance--]
"Unbumping" to jackson 2.9.10 (latest patch from September... at time of
writing) is _probably_ safer for others using or validating Avro 1.9.x.
My experience with jackson in big data is that the application will override
the jackson version anyway (e.g. Jackson 2.6, 2.7 and 2.9 in Spark 2.2, 2.3
and 2.4 respectively), so it makes little difference...
Probably the most conservative thing to do would be to unbump jackson AND merge
the PR (Approach #3: All of the Above)?
> getJsonStringEncoder() method not found on branch-1.9
> -----------------------------------------------------
>
> Key: AVRO-2632
> URL: https://issues.apache.org/jira/browse/AVRO-2632
> Project: Apache Avro
> Issue Type: Bug
> Components: build, java
> Reporter: Brian Lachniet
> Assignee: Brian Lachniet
> Priority: Major
>
> {{branch-1.9}} began failing Travis builds in [Build
> #1382|https://travis-ci.org/apache/avro/builds/607297589] with the following
> errors:
> {code}
> [ERROR] COMPILATION ERROR :
> [INFO] -------------------------------------------------------------
> [ERROR]
> /home/travis/build/apache/avro/lang/java/avro/src/main/java/org/apache/avro/SchemaBuilder.java:[2714,40]
> cannot find symbol
> symbol: method getJsonStringEncoder()
> location: class com.fasterxml.jackson.core.util.BufferRecyclers
> [ERROR]
> /home/travis/build/apache/avro/lang/java/avro/src/main/java/org/apache/avro/SchemaBuilder.java:[2718,40]
> cannot find symbol
> symbol: method getJsonStringEncoder()
> location: class com.fasterxml.jackson.core.util.BufferRecyclers
> {code}
> The Jackson version was bumped [in this set of
> changes|https://github.com/apache/avro/compare/fea6888bc211...f156063edb17].
> This seems like it could be related to the cause of the problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
