kojiromike commented on a change in pull request #847:
URL: https://github.com/apache/avro/pull/847#discussion_r419391638
##########
File path: doc/src/content/xdocs/spec.xml
##########
@@ -546,7 +546,7 @@
<section id="union_encoding">
<title>Unions</title>
- <p>A union is encoded by first writing a <code>long</code>
+ <p>A union is encoded by first writing an <code>int</code>
Review comment:
@anhldbk Agreed. I'm also asking you to add a similar note right here in
the docs, either as a footnote with an asterisk, or with parentheses. Sure,
we'll never see such a union in real life, but we should still document the
state of the implementation(s) as they are. That is, for C and C++, practically
an `int`, but theoretically a `long`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
