ypt opened a new pull request #937:
URL: https://github.com/apache/avro/pull/937


   https://issues.apache.org/jira/browse/AVRO-2907
   
   I've compared the output of the [Ruby 
implementation](https://github.com/apache/avro/blob/release-1.10.0/lang/ruby/lib/avro/schema.rb#L180)
 (originally implemented in https://github.com/apache/avro/pull/317) to the 
[Java 
implementation](https://github.com/apache/avro/blob/release-1.10.0/lang/java/avro/src/main/java/org/apache/avro/SchemaNormalization.java#L64),
 and it seems like the output of the Ruby implementation of 
`single_object_schema_fingerprint` is reversed in comparison.
   
   I believe that this is caused by [unnecessarily reversing the array 
traversal 
here](https://github.com/apache/avro/blob/release-1.10.0/lang/ruby/lib/avro/schema.rb#L184)
 during the bit mask + shift operation that constructs the little endian 
fingerprint for the message header - as the mask operations are already 
grabbing the least significant bytes first.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to