[ https://issues.apache.org/jira/browse/AVRO-3150?focusedWorklogId=650185&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650185 ]
ASF GitHub Bot logged work on AVRO-3150: ---------------------------------------- Author: ASF GitHub Bot Created on: 13/Sep/21 18:32 Start Date: 13/Sep/21 18:32 Worklog Time Spent: 10m Work Description: dkulp commented on pull request #1236: URL: https://github.com/apache/avro/pull/1236#issuecomment-918466642 Changed the checkstyle rule instead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@avro.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 650185) Time Spent: 20m (was: 10m) > Checkstyle requires LF line endings: add .gitattributes hint > ------------------------------------------------------------ > > Key: AVRO-3150 > URL: https://issues.apache.org/jira/browse/AVRO-3150 > Project: Apache Avro > Issue Type: Improvement > Components: java > Affects Versions: 1.10.2 > Reporter: Ryan > Assignee: Daniel Kulp > Priority: Major > Labels: pull-request-available > Fix For: 1.11.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Running the Java unit tests on a Windows machine with the commonly configured > git line ending configuration: > {quote}{{git config --global core.autocrlf true}} > {quote} > Results in test failure of: > {quote}{{NewlineAtEndOfFile: Expected line ending for file is LF(\n), but > CRLF(\r\n) is detected.}} > {quote} > This is due to a checkstyle rule. If the unit tests require LF line endings > then it would be helpful to add a .gitattributes file to automatically ensure > the correct line endings are used on git clone. -- This message was sent by Atlassian Jira (v8.3.4#803005)