[
https://issues.apache.org/jira/browse/AVRO-3238?focusedWorklogId=667096&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667096
]
ASF GitHub Bot logged work on AVRO-3238:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Oct/21 15:42
Start Date: 19/Oct/21 15:42
Worklog Time Spent: 10m
Work Description: zcsizmadia opened a new pull request #1376:
URL: https://github.com/apache/avro/pull/1376
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Avro
Jira](https://issues.apache.org/jira/browse/AVRO/3238)
- https://issues.apache.org/jira/browse/AVRO-3238
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [X] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@avro.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 667096)
Remaining Estimate: 0h
Time Spent: 10m
> Unify TargetFrameworks for C# projects
> --------------------------------------
>
> Key: AVRO-3238
> URL: https://issues.apache.org/jira/browse/AVRO-3238
> Project: Apache Avro
> Issue Type: Improvement
> Reporter: Zoltan Csizmadia
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> h3. Issues:
> # If netstandard2.0 is a target, no need to add net462, sonce .NET FW 4.6.1+
> supports using .NET STandard libraries
> # I dont think there is a need for .NET FW 4.0 support ay more
> # The csproj builds for different targets based on running on Windows or
> Linux
> # Many of the projects support different (maybe legacy) frameworks, e.g.
> ipc, ipc.test
> h3. Proposal:
>
> Add the following to {{common.props}} (root of all csharp projects):
> <PropertyGroup Label="Target Frameworks">
> <!-- Exe -->
>
> <DefaultExeTargetFrameworks>netcoreapp3.1;net5.0</DefaultExeTargetFrameworks>
> <!-- Library -->
>
> <DefaultLibraryTargetFrameworks>netstandard2.0;netstandard2.1</DefaultLibraryTargetFrameworks>
> <!-- Unit Tests -->
>
> <DefaultUnitTestsTargetFrameworks>$(DefaultExeTargetFrameworks)</DefaultUnitTestsTargetFrameworks>
> </PropertyGroup>
>
> Use the following for Exe projects:
> {{<TargetFrameworks>$(DefaultExeTargetFrameworks)</TargetFrameworks>}}
>
> Use the following for Library projects:
> {{<TargetFrameworks>$(DefaultLibraryTargetFrameworks)</TargetFrameworks>}}
>
> Use the following for Unit Tests projects:
> {{<TargetFrameworks>$(DefaultLibraryTargetFrameworks)</TargetFrameworks>}}
> h3. Pros
> # The projects builds are very uniform across Linux and Windows
> # New Target framework (e.g. the upcoming net6.0) is easy to add, just
> simple editing common.props
> h3. Cons
> .NET Framework 4.6+ will be supported (via .NET Standard 2.0), which in my
> opinion is acceptable in 2021
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
